Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1692
+1 LGTM, ran unit tests, verified the processors are in the assembly, and
ran some tests on a live NiFi. Thanks for the contribution, this is good
stuff! Merging to master
---
If your project
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1692
@mattyb149 just to register: TLSH requires more than 512 characters to work
so your hello message triggers a safety mechanism that routes the flow to
error.
I should have used error but I
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1692
pom has also been fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1692
@alopresto @mattyb149 last two commits should address the two residual
issues you identified.
One was a simple reference to HashContent.class instead of the fully
qualified class path as
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1692
Andy, easy to solve
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1692
@trixpan I have been reviewing this along with @mattyb149 and @bbende and
we believe there may be a dependency issue here. I had only reviewed the code
design via GitHub but upon trying to build
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1692
Will finish reviewing and merge shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1692
Thanks @trixpan . I will continue to review but I appreciate your efforts
in response to my comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1692
@alopresto - I put together the interface based approach and indeed it
seems a much cleaner code so thank you for pointing me into this direction.
The code has not been optimised and still
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1692
@apiri and now the comparison processor!!
For the record: I tried to illustrate the potential of the processor by
using two of the NiFi own 'pom.xml' and displaying how despite lack of 1 to
10 matches
Mail list logo
