Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1696
@jfrazee I resolved conflict with master (unrelated to the change).
I would agree that the "text" qualifier was indeed missing. Fixed.
---
If your project is set up for it, you can reply to
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1696
@trixpan I think there's a mistake in the last line of .gitattributes. It
is missing the 'text' qualifier and just is the file pattern and then eol. Let
me know if I've misunderstood; otherwise I'll
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1696
@jfrazee?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1696
@jfrazee this seems to be passing tests now. Let me know what you think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1696
@jfrazee now that HL7 is out of the way, giving it another try... Will let
you know when I am happy with code.
Cheers
---
If your project is set up for it, you can reply to this email and
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1696
@trixpan Do you know which files are problematic? I'm assuming the *.txt;
i.e., the content that's being encrypted. I'd figure it wouldn't matter for the
*.asc and *.pgp.
---
If your project is set
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1696
@jfrazee while we are doing HL7 is there any chance you can look at the
EncryptContent tests as well?
Due to the nature of PGP ASCII Armor files they use a mix of DOS and Unix
line format as
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1696
@trixpan You're right about the HL7 and it's actually ill-formed if you
don't use CR, crazy. For best results, though, we should just move the HL7
content into a String in the test class.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1696
Travis no likey :( Looks like some test files related to decompression
were created when the line endings were CRLF, they would have to be recreated
as well.
---
If your project is set up for
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1696
@joewitt as suspected HL7 does inded use CR as a segment separator so I
renamed the files to hl7 and treated hl7 as binary. Tests passed locally and I
am now checking what travis has to say
---
If
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1696
@joewitt - When doing this change I noticed some changes to HL7 files and
looking online it seems like HL7 uses CR as a "segment separator".
Would you mind if I renamed the relevant files
11 matches
Mail list logo
