[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-27 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1697 +1 as well. Thanks @YolandaMDavis. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-27 Thread brosander
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1697 +1 looks good to me, thoughts @mcgilman ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-27 Thread YolandaMDavis
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1697 Looks good to me, thanks @mcgilman ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-27 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1697 @YolandaMDavis I've added another commit [1] to print the response body when possible. If your happy with this addition, I'll amend it to your PR. Thanks. [1]

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-26 Thread YolandaMDavis
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1697 @mcgilman I addressed your comments above in the latest commit. Please let me know if you have any additional questions or feedback. --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-26 Thread YolandaMDavis
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1697 @mcgilman understood. It does makes sense to have more polite messaging given this new case. I'll work on those changes and update. --- If your project is set up for it, you can reply to

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1697 @YolandaMDavis Code changes look good. However, one thing I noticed is that the error provided when the specified proxied user lacks sufficient permissions could be made a little more user-friendly.

[GitHub] nifi issue #1697: NIFI-3695 - added proxy dn flag to support providing autho...

2017-04-26 Thread YolandaMDavis
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1697 @mcgilman and @brosander appreciate if you could take a look at this enhancement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as