[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-15 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1718 Thanks @trixpan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1718 Yes that was a typo. Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman I suspect when you wrote `DocumentTypeDTO` you meant `DocumentedTypeDTO`? If that is the case, hopefully this address the comment --- If your project is set up for it, you can reply to

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-09 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman - will adjust --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1718 Ok sounds good. Let's proceed with this PR and then we can file another JIRA for the UI work. I just started reviewing and noticed that the `DocumentTypeDTO` is missing the deprecation

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman Thank you for looking at this. Yes, I would say as long this part is ok we could merge. I also would prefer having the UI work done separately. Cheers --- If your project is set

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-08 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1718 @trixpan How did you want to handle this PR? Should we get this part merged into master and then the UI work can follow? The only reason this might be a good idea is that we won't have to struggle

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman based on the following screenshot( this is a snipped of data related to a locally deprecated `ListenLumberjack`) I suspect this should be a good starting point for the UX work