[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-06-26 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1747 Ran `contrib-check` and all tests pass. +1, merging. I made slight modifications to improve the `help` handling and fix some terminology (*flowfile* -> *flow* when referring to the actual file that

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-11 Thread Xsixteen
Github user Xsixteen commented on the issue: https://github.com/apache/nifi/pull/1747 Updated to SNAPSHOT version 1.3.0, then rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-10 Thread Xsixteen
Github user Xsixteen commented on the issue: https://github.com/apache/nifi/pull/1747 I have successfully squashed the commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-10 Thread josephxsxn
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/1747 Builds fine passed check-style. Tests pass. License headers exist. Tested on my custom workflow with success. Please rebase master from upstream and squash your 11 commits into 1 for the

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-10 Thread josephxsxn
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/1747 I think you just need a entry in your pom in the toolkit-assembly now and ull be all done :D Looks like it works well. Will test on some other clusters just to validate diversity.

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-09 Thread Xsixteen
Github user Xsixteen commented on the issue: https://github.com/apache/nifi/pull/1747 Joe, I added functionality to list max/min/avg for . Gray - I completely agree, I will add more testing if complexity increases. --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-09 Thread GrayGwizdz
Github user GrayGwizdz commented on the issue: https://github.com/apache/nifi/pull/1747 Reading through the code everything looks good, I always err on the side of the more test cases the better but I think you have your bases covered. --- If your project is set up for it, you can

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-09 Thread josephxsxn
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/1747 works great now on multiple differing flow.xml.gz's... I am thinking that perhaps we should include the min/max/avg flow files per queue as well just in case some users decides to set it to

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-08 Thread Xsixteen
Github user Xsixteen commented on the issue: https://github.com/apache/nifi/pull/1747 Fixed the issue with second Big Decimal division point. Added licensing information to project. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-08 Thread Xsixteen
Github user Xsixteen commented on the issue: https://github.com/apache/nifi/pull/1747 Updated, please try again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-08 Thread josephxsxn
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/1747 Test fails when building Looks trivial see below. Also built it with skipTests anyway just to run it again, on 1 Cluster I am getting a null. ```

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-04 Thread josephxsxn
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/1747 ignore my java -cp // java jar comments.. Can you mimic what the other existing tools do here with .bin and .sh scripts ?

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-04 Thread josephxsxn
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/1747 Also would it be possible to change the packaging so that it builds its in a 'java jar' manor so the admin doesnt have to go lookup the entire classname to run the utility? --- If your project

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-04 Thread josephxsxn
Github user josephxsxn commented on the issue: https://github.com/apache/nifi/pull/1747 I went and built this, you have alot of checkstyle issues - [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.15:check (check-style) on project