[GitHub] nifi issue #1831: NIFI-3942 Making IPLookupService reload the database file ...

2017-05-22 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1831 @bbende all looks good now. Was able to verify the functionality. +1 merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi issue #1831: NIFI-3942 Making IPLookupService reload the database file ...

2017-05-19 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1831 @markap14 Thanks for reviewing, I agree about the handling of the InvalidDatabaseException. I added another commit that catches the InvalidDatabaseException, then forces a reload and attempts the look

[GitHub] nifi issue #1831: NIFI-3942 Making IPLookupService reload the database file ...

2017-05-19 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1831 @bbende I very much like the idea of this PR. I tried to test it out, though, and it didn't behave as I was hoping. I downloaded the GeoLite2 database for ASN and for City. I set the