[GitHub] nifi issue #1985: NIFI-2529: added support for SSLContextService protocols i...

2017-09-27 Thread m-hogue
Github user m-hogue commented on the issue: https://github.com/apache/nifi/pull/1985 No worries, @alopresto. Thanks for the review! ---

[GitHub] nifi issue #1985: NIFI-2529: added support for SSLContextService protocols i...

2017-09-26 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1985 @m-hogue I apologize for the delay on this. I reviewed and verified that the tests pass, the checkstyle was good, and a flow I developed using `HandleHTTPRequest` and `HandleHTTPResponse` worked as

[GitHub] nifi issue #1985: NIFI-2529: added support for SSLContextService protocols i...

2017-08-31 Thread m-hogue
Github user m-hogue commented on the issue: https://github.com/apache/nifi/pull/1985 @trkurc @alopresto : I've made changes here in line with #1986 and forced the use of `RestrictedSSLContextService` here as well. This is ready for review. --- If your project is set up for it, you ca

[GitHub] nifi issue #1985: NIFI-2529: added support for SSLContextService protocols i...

2017-07-24 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1985 I have similar concerns with this as with [PR 1986](https://github.com/apache/nifi/pull/1986) about throwing exceptions on 71% of the available options in the protocol version dropdown. --- If yo

[GitHub] nifi issue #1985: NIFI-2529: added support for SSLContextService protocols i...

2017-07-24 Thread m-hogue
Github user m-hogue commented on the issue: https://github.com/apache/nifi/pull/1985 @trkurc : pushed same SSL protocol checks as added in #1985. Let me know if you'd like any additional changes. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] nifi issue #1985: NIFI-2529: added support for SSLContextService protocols i...

2017-07-13 Thread trkurc
Github user trkurc commented on the issue: https://github.com/apache/nifi/pull/1985 adding this to my review pile for the night --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en