Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2012
Thanks @jvwing for your advice and guidance.
Mans
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2012
Thanks for those updates, @mans2singh, everything looks good. I'll merge
shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2012
Hi @jvwing -
Thanks for your review.
I've updated the code based on your review (changed logging level for
not_found to debug and id check to empty + updates to error message and
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2012
I'm OK with the name "GetRethinkDB". Thanks for the tagging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2012
My question about the not_found relationship is not if we should have it or
not -- I think it is a great addition. My question is about the logging for
that code path. You log an error on line 150 wh
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2012
Hello @jvwing - I've updated the code based on your review comments
(updated notice, refactored constants to base class).
Regarding the name Get vs Fetch - I am trying to use the terminol
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2012
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
