Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2044
Closing per @mcgilman.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2044
Thanks @alopresto! This has been merged to master. I accidentally forgot to
add the 'This closes...' text to the commit message. Would you mind closing
this PR out? Thanks!
---
If your project is
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2044
I also considered passing a supplier rather than the master key to the
`KeyProviderFactory`, but the `EncryptedWriteAheadProvenanceRepository` already
has access to the master key retrieval code,
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2044
Thanks @mcgilman. I have moved the master key extraction out to
`EncryptedWriteAheadProvenanceRepository` and removed the `nifi-security-utils`
dependency on `nifi-properties-loader`. That module
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2044
@alopresto These refactorings look good. The backward compatibility support
for legacy configurations is also solid. One minor thing I'd like to
investigate further if we can remove the dependency
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2044
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
