[GitHub] nifi issue #2077: NIFI-4237 Improve error messaging on encryption failures

2017-08-12 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2077 I have a *number* of questions about the existing implementation, but those will be addressed in NIFI-3116. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] nifi issue #2077: NIFI-4237 Improve error messaging on encryption failures

2017-08-11 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2077 I would like to learn why EncryptionException is a RuntimeException and not a checked exception, but since that's not related per se, +1 LGTM, merging to master, thank you! --- If your project is

[GitHub] nifi issue #2077: NIFI-4237 Improve error messaging on encryption failures

2017-08-11 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2077 I added a unit test which ensures the log error output is more helpful for users when the `flow.xml.gz` decryption fails. Verify with deterministic cipher text vectors: ``` 196