[GitHub] nifi issue #2123: NIFI-4345 Added a MongoDB controller service and a lookup ...

2017-09-22 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2123 I took the liberty of changing the Lookup Key property to Lookup Value Field, and updated variables and unit tests and such. +1 LGTM, built and ran unit tests, also tried a flow with LookupRecord wi

[GitHub] nifi issue #2123: NIFI-4345 Added a MongoDB controller service and a lookup ...

2017-09-22 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2123 @MikeThomsen I have reviewed the updated PR. It looks like all of my concerns are addressed. Thanks for the new iteration! I'm a +1 as long as @mattyb149 's concerns are all addressed. Thanks! ---

[GitHub] nifi issue #2123: NIFI-4345 Added a MongoDB controller service and a lookup ...

2017-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2123 @markap14 Do you think you could take a look at the updates? ---

[GitHub] nifi issue #2123: NIFI-4345 Added a MongoDB controller service and a lookup ...

2017-09-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2123 @markap14 Updated based on your feedback and added the ability to merge either a single field or the entire Mongo result minus the _id field. ---

[GitHub] nifi issue #2123: NIFI-4345 Added a MongoDB controller service and a lookup ...

2017-09-07 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2123 @mattyb149 Ok should be good to go now. ---