Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
finally got time to get back on this one... if you want to have another
look @mattyb149
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
Hey @mattyb149 - I believe we added this one for Hive 3 processors but
forgot this PR. I know you're not available at the moment, but just a reminder
for when you're back ;) (or if someone else
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
Done @mattyb149 - thanks!
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2138
@pvillard31 Mind doing a rebase here, and updating the QUERY_TIMEOUT
property to use FlowFile Attribute scope? I pushed up a rebased branch with the
additional commit
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
Hey @mattyb149, I rebased against master to account for the changes made by
Mark in the test framework. Let me know if there is something else.
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2138
I talked to @markap14 about it, perhaps this fix is fine or we can just
change it to a boolean, but I'll let him take a look too.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
I already noticed this error while working on others PRs (I'm a bit
surprised I didn't notice the NPE on this PR...). It's because we're checking
if the processor is valid before enabling
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2138
I'm getting NPEs in the unit tests, something weird with MockPropertyValue
getting created without "expectExpressions" being set to anything, causing
isExpressionLanguagePresent() to throw the NPE
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
Thanks for the review @mattyb149 and @joewitt. I updated the property
description based on your comments. Regarding the unit test, since I'm using a
``HiveStatement`` object in the custom validate
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2138
The "unit tests" for TestSelectHiveQL use Derby as the database, only to
test the functionality of getting the "HiveQL" statement to the database and
parsing its results. In that vein, Derby
10 matches
Mail list logo
