Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
@christophercurrie, thanks again for the work on this infrastructure
project.
I merged these commits to master, except for the last commit "Limit NOTICE
to AWS SDK" for nifi-aws-service-api-n
Github user christophercurrie commented on the issue:
https://github.com/apache/nifi/pull/2140
Ok, I've added those files. Let me know if they look OK and if there's
anything else that needs doing.
---
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
@christophercurrie The outstanding item for now is a set of LICENSE/NOTICE
files for nifi-aws-service-api-nar, similar to what is now in the nifi-aws-nar.
I believe the NOTICE file can be pared down to
Github user christophercurrie commented on the issue:
https://github.com/apache/nifi/pull/2140
Yes, though I'm not sure what action items are left for me at this point.
---
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
@christophercurrie I think we're pretty close on this PR, any interest in
continuing?
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2140
@jvwing sorry I never responded to this... The results you got seem correct.
The part I wasn't sure about was that the `nifi-aws-nar-1.3.0.nar` has a
dependency on` nifi-standard-services-api-n
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
More migration notes:
* My 1.3.0 AWS processor worked OK without modification when used with this
PR.
* My 1.3.0 AWS controller service did not work with just the NAR file, with
the expect
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
Thanks for the update, @christophercurrie . This PR is looking pretty good:
* Passes the full suite of unit tests with contrib-check.
* AWS processors and controller service still work OK in my
Github user christophercurrie commented on the issue:
https://github.com/apache/nifi/pull/2140
@jvwing I have pushed a commit that removes all unnecessary changes from
the PR. Sorry for the delay.
---
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
Thanks, @bbende, I'll take up the migration guidance for the wiki. As part
of reviewing this PR, I am building some sample processor and service projects
to reproduce the problems and check the fix.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2140
Regarding the migration strategy... Lets make sure we document on the
migration wiki page [1] that anyone who built custom components using the AWS
controller service should rebuild them with the new d
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
Please add the commits to this one. It usually helps reviewing to see the
commits separately, and it's easy enough to squash at the end.
---
Github user christophercurrie commented on the issue:
https://github.com/apache/nifi/pull/2140
Not a problem on the reverts. The original instructions asked for a
squashed commit. Should I create a new smaller PR, or add the revert commit to
this one?
---
Github user christophercurrie commented on the issue:
https://github.com/apache/nifi/pull/2140
How smooth their experience will be will probably depend upon their
internal project practices. Since the `nifi-aws-processors` package would have
been a required dependency for such custom
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
@christophercurrie - With respect to a transition plan, I'm not sure
exactly what we need. I'll have to get back to you on that. In vague concept,
users who have built custom processors and custom co
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2140
Reviewing... I agree the CI failure may not be related to this change.
`mvn clean install -Pcontrib-check` worked OK for me.
---
Github user christophercurrie commented on the issue:
https://github.com/apache/nifi/pull/2140
The failed CI builds seem to be failing for other PRs and do not appear to
be caused by this change.
---
17 matches
Mail list logo
