Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2150
Yes. +1, merging to master, thanks!
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2150
@pvillard31 @m-hogue Think we can close the loop on this one?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2150
Looks good to me. The only change I'd recommend is do a squashed commit so
your patch is just one commit.
Not a core committer, but FWIW +1
---
Github user m-hogue commented on the issue:
https://github.com/apache/nifi/pull/2150
@MikeThomsen : I've added your suggestions. Please let me know if you'd
like any more changes.
---
Github user m-hogue commented on the issue:
https://github.com/apache/nifi/pull/2150
Thanks for the review, @MikeThomsen! I agree & I'll make all of these
changes.
---
Github user m-hogue commented on the issue:
https://github.com/apache/nifi/pull/2150
Since there's not a clean way to unit test this, the way i tested was to
change unit tests and observe that there were etag cache hits until `max-age=1`
seconds had passed, when a network request
