Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2226
+1 as well, merging to master, thanks guys
---
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2226
+1, locally it builds and passes all the tests
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2226
Are you comfortable giving a +1 without the other test failures? If so we
can get a committer to merge. Thanks to both @mgaido91 and @patricker for
improvements.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2226
thanks @mattyb149. The test failures are not related to this PR. They are
caused by 3ca7c3e7a19c7f496a214d9b93ace43b1507c9ec. I am investigating them. I
am not sure if it is possible to re-trigger a
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2226
We don't need to get rid of those tests; rather I think if no EL is
present, then we should try parsing the schema for validity. It will be
reparsed in onTrigger() anyway (whether it has EL or not).
Github user mgaido91 commented on the issue:
https://github.com/apache/nifi/pull/2226
@mattyb149 there is a test failure because I just cherry-picked my changes
on top of your PR, so when I run the tests, I didn't run the test you added
here (sorry, my bad). This test is not valid any
