[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2285 So, I'd prefer leaving as it is if it's not too critical. ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2285 @JohannesDaniel Technically, we can [amend old commit info](https://stackoverflow.com/questions/3042437/change-commit-author-at-one-specific-commit). However, I think it requires a force push, wh

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 Ah I see. Sorry for this. Will we leave it as it (for this commit) is or can we fix this? ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2285 @JohannesDaniel Would you check your working environment setting, especially email address? I just squashed commits into one and pushed into master branch, didn't modify author info. https://

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 @ijokarumawak not too important, but do you know why this commit is not linked to my account? it is linked to "U-WOODMARK\johannes.peter" ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2285 @JohannesDaniel Thanks for the updates. Now it LGTM, +1. Merging in. Thank you for your contribution! ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 I replaced the values by static imports ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 I made TestGetSolr a bit more simpler by adding a method for the generic creation of TestRunners. I moved all remaining PropertyDescriptors from SolrProcessor to SolrUtils as they will be neede

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 (tested both processors in local build) ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 Restructured the methods as discussed in JIRA. Additionally, I improved the unit tests for GetSolr ---