[GitHub] nifi issue #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-11 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2394 Thanks @mgaido91! This has been merged to master. ---

[GitHub] nifi issue #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-11 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2394 thanks for your suggestions and help @mcgilman. I updated the PR accordingly. Thanks. ---

[GitHub] nifi issue #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2394 The change should be pretty straight forward. Here is an example of setting the title on the SVG elements [1]. In this example however, the tooltip is dynamic and needs to be regularly updated. Your

[GitHub] nifi issue #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/nifi/pull/2394 @mcgilman yes, sure, thanks for your comment. Just one question before proceeding. Doing this might involve some refactoring/non-trivial js, since process groups are in the canvas and therefore `titl

[GitHub] nifi issue #2394: NIFI-4764: Add tooltips to status bar icons

2018-01-10 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2394 Thanks for submitting a PR for this @mgaido91! Would you be able to also update the tooltips on the icons on the Process Group node on the canvas? They should be in nf-process-group.js. Than