Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2430
+1 LGTM, ran the unit tests and tried on a live NiFi instance with both
Ambari and Record modes. The only thing I noticed (that should be its own Jira)
is that the RecordWriter used by the reporting
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
Done @mattyb149, thanks!
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2430
Mind rebasing this? Please and thanks!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
@mattyb149 - pushed another commit with unit tests and doc
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
@mattyb149 - this is not the final version, I still have unit tests and
"additional details" doc to add, but wanted to give you an update in case you
want to have a look and if you already have fee
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2430
I like all those ideas!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
What about adding a property to let the user decide the output format:
- "Output format" with two options: "Ambari Metrics Collector format" or
"Record based format"
- "Record writer": this
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2430
Ugh that's true, I'm not a fan of dynamic keys. Since the schema would be
generated by the reporting task, then we could create a schema for the example
above, but then each flow file would have its
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
Thanks for your comments @mattyb149 - I just pushed a commit that should
address everything.
Regarding the record approach you suggested. Even though I really like the
idea, I'm not sure t
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
That's a great idea! I'll have a look.
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2430
Reusing the Ambari format certainly makes this one easier to implement, and
as you said the user can convert later with a record processor, but I'm
thinking it might be best to be able to specify th
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2430
I'll need to update this PR if #2431 is merged first.
---
12 matches
Mail list logo
