Github user david-streamlio commented on the issue:
https://github.com/apache/nifi/pull/2553
Alright, sounds good.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
Yeah. Since this is your first time, I'd recommend backing up the repo
before trying it. Once you've gotten them down to one commit, it won't need to
be done again until the review process is done
Github user david-streamlio commented on the issue:
https://github.com/apache/nifi/pull/2553
So the goal is to get my 23 commits squashed down into a single commit?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
The rule of thumb there is to be patient and do it multiple steps with as
many commits as you have in these two branches. I'd recommend only squashing a
few commits together a time until 4914 is o
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
Read [this blog
post](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html).
It goes into good detail about squashing commits during a rebase, along with
the caveats in doin
Github user david-streamlio commented on the issue:
https://github.com/apache/nifi/pull/2553
At this risk of sounding stupid, can you spell out the steps you are
suggesting? I want to make sure I don't screw up the process. I will close
this PR once I "rebase 4914 and squash it into
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
Ok. If you merged 4908 into 4914, go ahead and close out this out. Also, it
would be a good idea to rebase 4914 and squash it into one commit starting out
for a code review.
---
Github user david-streamlio commented on the issue:
https://github.com/apache/nifi/pull/2553
Thanks for the update.I have merged my changes that came from your code
review into the NIFI-4914-rebase PR as well. That PR has extends the base
Pulsar processor capabilities to include
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
@david-streamlio I'm going to try to get back to this very soon.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
@david-streamlio thanks for the link.
> Is there another car bundle that uses a Docker image for integration
testing that I can use as an example?
The Mongo package, sorta. We wro
Github user david-streamlio commented on the issue:
https://github.com/apache/nifi/pull/2553
@MikeThomsen We have a pre-configured Docker image that has Pulsar if you
want to use that for testing. See https://streaml.io/docs/getting-started. for
detailed instructions.
---
Github user david-streamlio commented on the issue:
https://github.com/apache/nifi/pull/2553
@MikeThomsen Is there another car bundle that uses a Docker image for
integration testing that I can use as an example?
I will clean up the formatting / style errors.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
You should strongly consider setting up some integration tests that can be
run against a simple Docker image. All you have to do with NiFi to get that
done is add a few classes with "IT" at the en
13 matches
Mail list logo
