Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2615
+1 LGTM, ran full build with unit tests, tried the lookup service with a
nested record and everything worked fine. Thanks for the improvement! Merging
to master
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
[ES_Lookup_Test.xml.txt](https://github.com/apache/nifi/files/2386507/ES_Lookup_Test.xml.txt)
[5051 Kibana
Commands](https://github.com/apache/nifi/files/2386508/5051.kibana.txt)
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2615
Reviewing...
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 can we close this out?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 can we merge?
---
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2615
@MikeThomsen I would maybe put a comment in the `src/test/java/.gitignore`
file explaining why it's there so someone in the future doesn't see it as a
superfluous tooling artifact and remove it, and
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
Should be all good to go now.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 Refactored the query builder.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@pvillard31 @mattyb149 changes checked in.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 @pvillard31 Changed the query model as requested and it's ready
for final review AFAICT.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 changed the query model per the discussion above and changed the
tests to be Groovy so that the inline JSON, etc. would be a lot cleaner to read.
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2615
Reviewing...
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 I converted it over to be a subclass of `SchemaRegistryService`.
Let me know if it needs anything else.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 Can you comment on the schema detection strategy issue I raised
here?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 Done.
---
15 matches
Mail list logo
