[GitHub] nifi issue #2638: NIFI-5082: Added support for custom Oracle timestamp types...

2018-04-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2638 +1 LGTM. Passed the build and it matches my rough understanding of the issues w/ Oracle as well. I'm good to merge this if you don't think it needs further review. ---

[GitHub] nifi issue #2638: NIFI-5082: Added support for custom Oracle timestamp types...

2018-04-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2638 I REALLY didn't want to have to do this explicit Oracle stuff in the generic code, but the other options I tried weren't viable. I tried isolating the SQL type conversion to the DatabaseAdapters, bu