Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2648
@kevdoran LGTM +1. Contrib-check at Travis passed and locally as well.
Merging.
---
Github user kevdoran commented on the issue:
https://github.com/apache/nifi/pull/2648
Aside from the issue with the ./secure_hash.key file being created in an
odd location, all other issues should be addressed now. If someone can verify
(the more platforms we have coverage on, the bet
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2648
for good measure those tests fail whether I'm parallel building or not so
fortunately it is repeatable...was worried it was due to parallel building
---
Github user kevdoran commented on the issue:
https://github.com/apache/nifi/pull/2648
Ok, thanks. good to know. I'll make that change and also fix or disable
those tests. Will update soon
---
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2648
I dont think so @kevdoran because it should be included by default going
forward unless it were overridden in a lower level/module pom. The excludes
line having combine.children is doing that so it s
Github user kevdoran commented on the issue:
https://github.com/apache/nifi/pull/2648
Thanks for taking a look @joewitt. I'll try a build on Linux and try to
reproduce that.
I agree on placing the consoleOutput=true setting in the root pom. Does it
also need to be included i
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2648
to clarify regarding the above i was seeing that on a linux system.
Travis-CI did pass.
---
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2648
@kevdoran i like the changes for travis using the igores file input to
grep! Left a comment to consider moving consoleOutput of rat to the top level
pom. And I am still seeing test issues for
