Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2672
+1 LGTM, made a couple of edits before merging (see comments), thanks for
the improvement! Merging to master
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2672
[Added a Jira ticket](https://issues.apache.org/jira/browse/NIFI-5197) to
track the issue with the invalid scope bugs.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2672
@mattyb149 I just changed the override to be the one without a parameter. I
agree that there should be a task for squashing the scope bugs, but do the few
that got squashed here need to be cherry
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2672
I think the invalid scopes thing should be done in a separate Jira, there
are more than just the ones above (~40 in total) so I think we should tackle
them all at once, and have this PR just call ev
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2672
@markap14 I added a detailed comment describing why I did what I did and
fixed a few processors that had invalid scopes applied to their properties.
Build seems totally fine now. Let me know if yo
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2672
I think making this consistent for testing is a good idea. The fact that
the Mock classes in nifi can replicate the runtime behavior is very important
to implementors.
I think that the
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2672
@pvillard31 can you take a look?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2672
@markap14 Any feedback?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2672
@pvillard31 @joewitt Could one of you do a code review on this? It aims to
roll back a little of the new testing behavior that breaks
evaluateExpressionLanguage(FlowFile) when the input is null. T
