Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2749
+1 LGTM, let's tackle the FTP stuff in a different Jira. Thanks for the
improvement! Merging to master
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2749
@mattyb149 Regarding your question about what is blocked by this PR, there
are some integration tests in the Mongo package that break without this because
the Mongo processors have optional input.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2749
@mattyb149 @alopresto I backed out the FTP-related changes and put a
temporary fix in there that handles the edge case that was impacting the FTP
processors. There are two cases that cause trouble
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2749
Sorry, I didn't get a notification about this one. I've been working on
some other things but will see if I can look at this tomorrow. It's 50/50 right
now.
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2749
What is the current state of this PR? The tests are passing but they were
before that. Does ListFTP or some processor break without this fix? If not, one
comment above implies something would be bro
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2749
@mattyb149 can we close this out?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2749
@joewitt can you review?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2749
@alopresto can you review? See comment above.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2749
@markap14 can you review? Since you brought this up on the dev list, here's
the simple summary:
The test framework is too strict on processors where input is optional. In
those cases, it'
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2749
@joewitt can you review this commit?
---
10 matches
Mail list logo
