Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
Closed an created a new pull request for the same issue from a clean state:
https://github.com/apache/nifi/pull/3165
---
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
@MikeThomsen This is kind of tricky: NiFi flows refer the precise version
of NiFi within the flow XML file, so you have something like this for the
processor definitions:
```
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2872
> Hi @MikeThomsen sorry for the delay, I have been just very busy.
Thanks. I've got a lot on my plate as well, but will try to find some time
early this week to review.
---
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
Hi @MikeThomsen sorry for the delay, I have been just very busy. It turns
out there have been some changes in the flow XML format, which I have fixed
against the latest GA version: now
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
Hi @MikeThomsen , hi @alopresto , OK, I've implemented my changes according
your recommendations: we now have a dedicated profile for running tests, which
is disabled by default.
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
That makes sense: I'll look into that... once I have a tiny bit of time...
---
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2872
I think there should be a Maven module for the test harness which is
disabled by default and can be activated with a flag like `mvn clean test
-Ptest-harness`.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2872
@peter-gergely-horvath ok. I'm pretty sure that the surefire plugin can be
disabled in the POM, but manually activated, so we'll need to look at that
because those tests should be runnable if
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
Hi @MikeThomsen I _intentionally_ have no test configuration in the project
(at least for now): they are merely *samples* of what can be done, but they
should not be executed as part of
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
@MikeThomsen OK, in the future, I will follow that approach. For this pull
request, please review as it is, since the current state contains everything in
a squashed commit.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2872
@peter-gergely-horvath the consensus seems to be just keep pushing new
commits and let us do a squashed commit for you because that helps GitHub
maintain the context of feedback in a review.
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
@MikeThomsen The pull request contains the latest changes; after @lfrancke
had made his comments, I corrected the issues mentioned, nuked my whole fork
and force-pushed my new version.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2872
@peter-gergely-horvath can you push that commit?
---
Github user lfrancke commented on the issue:
https://github.com/apache/nifi/pull/2872
Thanks! Unfortunately for some reason I can't see your new commit...
(I should maybe also add that I'm not a committer, I wast just interested
in this PR)
---
Github user peter-gergely-horvath commented on the issue:
https://github.com/apache/nifi/pull/2872
Hi @lfrancke I've fixed the issues you noticed. Can you please review the
current state?
---
15 matches
Mail list logo
