[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3032 @colindean the releases aren't on a set schedule and are decided by discussion on the d...@nifi.apache.org mailing list, but I think you're right in your feeling that a release is probably coming up

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread colindean
Github user colindean commented on the issue: https://github.com/apache/nifi/pull/3032 That's fair. I feel like a release is coming up. Looking at the calendar, it seems like it happens in the first two weeks of each quarter. There's a been a lot of commits since 1.7.1! We're OK dropp

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3032 No I couldn't reproduce, Oracle and Postgres don't have native unsigned types (they use contraints/checks). Wanted to try a few DBs/types just in case, seems even with standards (SQL, JDBC) everybod

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread colindean
Github user colindean commented on the issue: https://github.com/apache/nifi/pull/3032 Awesome! @mattyb149, where you able to reproduce the bug on other database software/driver combinations? Was this behavior unique to MySQL 5.0.x and driver 5.1.x? I wasn't able to

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3032 +1 LGTM, ran full build with tests, reproduced the issue before applying the PR and verified on MySQL that the issue no longer occurs. Also tried similar data types on Oracle and PostgreSQL. Thanks

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread colindean
Github user colindean commented on the issue: https://github.com/apache/nifi/pull/3032 I'll note that I built this NAR and used it for a job running against the production server in which I originally observed the problem. That job did not display the behavior and seems to have retrie

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-27 Thread colindean
Github user colindean commented on the issue: https://github.com/apache/nifi/pull/3032 @mattyb149 Thoughts? ---

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3032 Reviewing... ---

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-26 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3032 Hey @colindean, I'll let @bbende & @mattyb149 have a look on the code but as long as 1 of the 3 Travis builds is green, you're good to go. We have to fix the intermittent issues on the builds but t

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-25 Thread colindean
Github user colindean commented on the issue: https://github.com/apache/nifi/pull/3032 The test failure seems to be a timeout from a test unrelated to what I changed but still within the nifi-standard-processors maven component: ``` [ERROR] Tests run: 3, Failures: 0, Error