[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-11-16 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/3107 Thanks for the suggestion. Rebase against master, solve conflicts and squash into single commit. ---

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-11-15 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/3107 Hey, @yjhyjhyjh0, can you rebase against master and push a new squashed commit? I think this is ready to merge if we resolve this new code conflict. ---

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-11-05 Thread patricker
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/3107 @mattyb149 Not sure if you've seen my latest reply to the email chain, but it looks like this is already a standard pattern used in ~12 other processors. Would love to see the discussion come to a c

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-10-27 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/3107 Thanks for the remind, there are some nice discussions in the mailing list. I'll fix capitalization after we have consensus. ---

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3107 Just to connect the dots here, there is some dissent from the PMC about this approach, so we should do our best to reach consensus on the mailing list before this PR is merged, in case the direction

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-10-24 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3107 Reviewing... ---