Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/483
Fantastic, thanks @trixpan!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/483
@JPercivall - done. Just give travis a few minutes and we should be good to
go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/483
Hey @trixpan, Joe checked out the commit and gave a +1 on the ticket. Could
you rebase this one more time and I'll merge it in?
---
If your project is set up for it, you can reply to this email and
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/483
Ah thank you for fixing the rebase @trixpan, no problem.
@joewitt, I refactored some of the concurrent logic that was being used in
ListenSMTP. If you have some time, I'd appreciate a second
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/483
@JPercivall rebase fixed. My bad, apologies for that.
Regarding the InterruptException - Thanks for the clarification. Makes
total sense that you accept the interrupt and deal with whatever th
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/483
@JPercivall Fixing the rebase. Please hold
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/483
Thank you for the complements. The "InterruptedException" essentially means
something want this thread to stop for some reason (here's an overview of
[this](http://www.yegor256.com/2015/10/20/interr
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/483
@JPercivall Beautiful code! Loved it. Interesting to see your programming
thinking. Great lesson (specially because I tried to achieve a similar - though
more covoluted - logic previously and failed. h
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/483
Hey @trixpan, I just finished checking out your latest commit. I was having
trouble wording the how to properly make the onTrigger and data methods work in
sync, so I did some reworking and created
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/483
I use this:
https://gist.github.com/trixpan/3463148366aacbaa7183267a10afe25e#file-listensmtp-template
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/483
@trixpan do you by chance have a template that I can use to validate the
processors with?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/483
@trixpan Exactly. "Having a single connection is enough" was my expected
behavior, but it wasn't. The error doesn't happen all the time, but quit often,
so I think it's a race condition. The relat
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/483
@ijokarumawak - thanks for looking at it.
So just for me to confirm:
PutEmail connects and tries to use SSL. This fails. It holds the socket
PutEmail connects again with plain
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/483
@trixpan I am not sure 100% yet about the javax.mail.SocketFetcher's
behavior, but I recommend to set higher value as default for `Maximum number of
SMTP connection`, such as `1,000`, and probably
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/483
@trixpan I found why I got the `Too many connection` exception.
I didn't setup SSL at ListenSMTP processor, so it was expecting plain text
connections.
But PutEmail uses `javax.net.ssl
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/483
@ijokarumawak Still not clear to me how you are reaching the error.
Also, note the QUIT message is not a requirement, a client may chose to
send more than a message per session, example:
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/483
Looked at the SMTP server side, org.subethamail.smtp.server.SMTPServer to
investigate how it uses maxConnections. It's used as a Semaphore. With
successful transport, there's a QUIT message and se
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/483
@JPercivall @trixpan Great review process, I learned a lot from it, thank
you!
I pulled the latest PR and tested, Unit test passed, however, I got
following error if `Maximum number of SM
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/483
The email-nar does not have a LICENSE or NOTICE in its src directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/483
@trixpan Thanks for the updates and sorry for taking this so long to get
merged. I've checkout the latest PR and:
- Confirmed NOTICE is updated
- Unit tests run successfully, without r
20 matches
Mail list logo
