[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-12 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/827 the new PR uses instance array for buffer. This will be a problem under multiple threads. the references in LICENSE to JOpt Simple and JLines..is this copy and paste or are those really in

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan with regard to "Read timeout" I've just added better exception handling to notify user

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan just confirmed, the "Read timed out" exception is the correct behavior, but I will wrap it into a nicer log message. But just to confirm the behavior is expected --- If your project is set up

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz have you pushed the notification recently? I got just an abrupt termination ``` $ telnet 0 2525 Trying 0.0.0.0... Connected to 0. Escape character is '^]'. 220

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 The above is actually correct and is exactly what we were aiming for. No data loss. There is actually new test that validates for that exact message. So all is good. User is notified that something went

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 Stopping the processor with an agent connected also seems to throw an exception (not sure if expected) ``` 2016-08-12 01:42:06,593 INFO [StandardProcessScheduler Thread-7]

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 1. Start ListenSMTP port 2525 with 1 maximum connection, 10 seconds of timeout ``` $ telnet 0 2525 Trying 0.0.0.0... Connected to 0. Escape character is '^]'. 220 localhost

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan i think you've closed client while it was in he middle of reading InputStream. If that's the case then yes the stack trace above is exactly what one would expect. --- If your project is set

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan could you please describe scenario that triggered the above exception? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 Ok @joewitt @trixpan latest comments are addressed in the latest commit. Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan and @olegz great discussion going here. I just ask you find a good 'this is right for first iteration' then let's get it in the hands of users and get more feedback to improve on. We can

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 i see now. Putting it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz You are clearly confusing envelope (the data exchanged within an SMTP session) with header information (the data added to the body of the message after the DATA command). They don't

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/827 based on @olegz and @trixpan comments about port 25 i agree we should leave it unset. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz - Tested the processor and other than the view that attributes should not be removed (as they are useful for many auditing and downstream applications) and a few remarks on SubEthaSMTP