Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
+1 LGTM, thanks again for the great contribution! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/877
Improvements are in, along with a few extra steps in the tests to make sure
these attributes are checking out.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Awesome, thanks! Looking forward to these improvements, will make QDT much
more flexible and powerful
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/877
I'll get it in. I didn't add any tests around those attributes, they were
more of an after thought, so I'll throw a couple of those in too.
---
If your project is set up for it, you can reply to th
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Everything looks good and works well, thanks! @patricker what do you think
about adding fragment.count? Could be a later improvement but I think it'd be a
good thing to add if not too troublesome
-
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/877
I got CheckStyle working in IntelliJ this morning and all those issues
popped right up.
Checkin comment amended.
---
If your project is set up for it, you can reply to this email and have your
r
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Your second commit is labelled NIFI-2584, but I believe it's for NIFI-2583.
Would you mind re-submitting with the new commit label? Just want to make sure
when the merge happens that the Jira trail i
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/877
Yeah, I haven't loaded in the NiFi style guide into IntelliJ; it was just
trying to be helpful with the * imports.
Should be all updated.
All of my test cases are very positive outco
