GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1650
NIFI-2661 - Abstract the GeoEnrichIP processor
NIFI-2661 - Introduce ISPEnrichIP Processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review o
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113245854
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -208,6 +120,8 @@ publ
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113244694
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -70,6 +55,7 @@
@
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113246522
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestISPEnrichIP.java
---
@@ -0,0 +1,310 @@
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113247007
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/ISPEnrichIP.java
---
@@ -0,0 +1,132 @@
+/
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113340946
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -208,6 +120,8 @@ public
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113411154
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -70,6 +55,7 @@
@Wr
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113411573
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -208,6 +120,8 @@ public
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113428044
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/ISPEnrichIP.java
---
@@ -0,0 +1,132 @@
+/*
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113431000
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestISPEnrichIP.java
---
@@ -0,0 +1,310 @@
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113442128
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -76,26 +76,36 @@ publ
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1650#discussion_r113442378
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -76,26 +76,36 @@ publ
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
13 matches
Mail list logo
