[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125171988 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java --- @@ -47,7 +46,7 @@

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125171843 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java --- @@ -389,30 +391,

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread lfrancke
Github user lfrancke commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125168375 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java --- @@ -389,30 +39

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread lfrancke
Github user lfrancke commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125168336 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPGetter.java --- @@ -84,17 +83,21 @@ publi

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread lfrancke
Github user lfrancke commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125168289 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java --- @@ -47,7 +46,7 @@

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread lfrancke
Github user lfrancke commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125168182 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml --- @@ -20,8 +20,8 @@ language governing permissions and limitations under the Licen

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread lfrancke
Github user lfrancke commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125168139 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml --- @@ -20,8 +20,8 @@ language governing permissions and limitations under the Licen

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125167130 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java --- @@ -389,30 +391,

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125165016 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPUtils.java --- @@ -191,26 +164,6 @@ private

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125164368 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPGetter.java --- @@ -84,17 +83,21 @@ public

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125163077 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPUtils.java --- @@ -48,77 +42,58 @@ /**

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125163015 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java --- @@ -47,7 +46,7 @@

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125162753 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java --- @@ -47,7 +46,7 @@

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125162646 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml --- @@ -20,8 +20,8 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1941: NIFI-4099

2017-07-01 Thread trkurc
Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/1941#discussion_r125162625 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml --- @@ -20,8 +20,8 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1941: NIFI-4099

2017-06-26 Thread lfrancke
GitHub user lfrancke opened a pull request: https://github.com/apache/nifi/pull/1941 NIFI-4099 - Code cleanup (consistent formatting, naming etc.) - Update of SNMP4J from 1.10.1 to 2.5.6 - Fixes restartability issue because snmpTarget was not recreated - Updates SNMPUtils