[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71087720 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71087671 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71087628 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71074419 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71074368 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71074365 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71074344 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71074306 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71073752 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71073744 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71073287 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-13 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/645 NIFI-2157: Add GenerateTableFetch processor Refactored common code out of QueryDatabaseTable into an Abstract base class, which involved some refactor of QueryDatabaseTable as well as the added