Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-14 Thread via GitHub
szaszm closed pull request #1681: MINIFICPP-1797 Python bootstrap (part 1) URL: https://github.com/apache/nifi-minifi-cpp/pull/1681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-13 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1522706091 ## bootstrap/package_manager.py: ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-12 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1521748017 ## bootstrap/py_bootstrap.bat: ## @@ -0,0 +1,29 @@ +@echo off + +REM Check if Python is installed +where python > nul 2>&1 +if %errorlevel% neq 0 ( +

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-12 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1521747343 ## Windows.md: ## @@ -120,9 +120,22 @@ A basic working CMake configuration can be inferred from the `win_build_vs.bat`. ``` mkdir build cd build -cmake

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-12 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1521347526 ## Windows.md: ## Review Comment: I think most of the file should go under manual bootstrap and build, including Building with Visual Studio, and Building

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1520163594 ## bootstrap/py_bootstrap.bat: ## @@ -0,0 +1,29 @@ +@echo off + +REM Check if Python is installed +where python > nul 2>&1 +if %errorlevel% neq 0 ( +echo

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1520154175 ## .github/workflows/ci.yml: ## @@ -75,12 +131,72 @@ jobs: timeout-minutes: 240 env: LUA_DIR: D:\a\nifi-minifi-cpp\nifi-minifi-cpp\.lua +

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1520152166 ## bootstrap/package_manager.py: ## @@ -0,0 +1,259 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1514638068 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import Dict +

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1514586297 ## bootstrap/py_bootstrap.bat: ## @@ -0,0 +1,29 @@ +@echo off + +REM Check if Python is installed +where python > nul 2>&1 +if %errorlevel% neq 0 ( +echo

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1514584816 ## bootstrap/package_manager.py: ## @@ -0,0 +1,259 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
szaszm commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1980997954 > This looks interesting 樂 , does the qouted path look correct? Is it the same that vswhere returns? It doesn't exist. It seems to have stemmed from an earlier build

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
martinzink commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1979056150 > In the same Windows environment I had issues with `vswhere`, I also had issue with the compiler command line after installing vswhere with scoop and refusing the offered

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1513040448 ## bootstrap/package_manager.py: ## @@ -0,0 +1,259 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-04 Thread via GitHub
szaszm commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1977041853 In the same Windows environment I had issues with `vswhere`, I also had issue with the compiler command line after installing vswhere with scoop and refusing the offered choco

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-04 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1511474443 ## bootstrap/package_manager.py: ## @@ -0,0 +1,259 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-04 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1511277613 ## bootstrap/package_manager.py: ## @@ -0,0 +1,259 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-04 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1511242466 ## .github/workflows/ci.yml: ## @@ -75,12 +131,72 @@ jobs: timeout-minutes: 240 env: LUA_DIR: D:\a\nifi-minifi-cpp\nifi-minifi-cpp\.lua +

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-04 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1511239034 ## extensions/grafana-loki/tests/PushGrafanaLokiRESTTest.cpp: ## Review Comment: thx for fixing this, I also ran into this issue a few weeks ago. --

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-01 Thread via GitHub
martinzink commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1973123420 > An other issue I had with the minificontroller build was this on Windows: > > ``` > FAILED: bin/minificontroller.exe > cmd.exe /C "cd . && "C:\Program

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-01 Thread via GitHub
martinzink commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1972985944 > I created a clean new Windows VM and tried out the new python bootstrap to set up the environment. When it installed the dependencies and got into the build menu I exited

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-02-27 Thread via GitHub
lordgamez commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1966498436 I created a clean new Windows VM and tried out the new python bootstrap to set up the environment. When it installed the dependencies and got into the build menu I exited the

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-02-20 Thread via GitHub
martinzink commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1954026766 > Do we want to remove `/bootstrap.sh`? Or are we keeping it for a while until possible kinks are ironed out with the new bootstrap? I think the latter would be better.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-02-20 Thread via GitHub
lordgamez commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1954025505 An other issue I had with the minificontroller build was this on Windows: ``` FAILED: bin/minificontroller.exe cmd.exe /C "cd . && "C:\Program

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-02-20 Thread via GitHub
lordgamez commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1953878314 > > I tried running this on windows 10, in a VS2022 developer command prompt. It prompted me to install the vs2022 build tools, which shouldn't be necessary with a full VS

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-02-15 Thread via GitHub
martinzink commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1946252397 > I tried running this on windows 10, in a VS2022 developer command prompt. It prompted me to install the vs2022 build tools, which shouldn't be necessary with a full VS

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-02-13 Thread via GitHub
fgerlits commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1487979767 ## bootstrap/py_bootstrap.sh: ## Review Comment: To accomodate users who don't read instructions, we should first check if `python` and `python-venv`

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-02-06 Thread via GitHub
szaszm commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1929456214 I tried running this on windows 10, in a VS2022 developer command prompt. It prompted me to install the vs2022 build tools, which shouldn't be necessary with a full VS

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-22 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1461704026 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-09 Thread via GitHub
lordgamez commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1445881214 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-08 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1444692735 ## bootstrap/main.py: ## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-08 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1444528599 ## bootstrap/main.py: ## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-03 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1440609170 ## bootstrap/package_manager.py: ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-03 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1440609170 ## bootstrap/package_manager.py: ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-03 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1440607564 ## bootstrap/package_manager.py: ## @@ -0,0 +1,325 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-01-03 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1440605842 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-12 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1424686652 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-12 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1424034289 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-12 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1424035886 ## bootstrap/main.py: ## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-11 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1422556409 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-11 Thread via GitHub
lordgamez commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1422546555 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-11 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1422537500 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1839101077 I've refactored pretty much the whole thing. Now it only installs the packages if they are not installed. Rewrote the CI to use the new bootstrapping process. On

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414218470 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414216533 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414213464 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414212713 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414212288 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414211453 ## README.md: ## @@ -304,8 +304,30 @@ sudo brew install libpcap ### Bootstrapping -- MiNiFi C++ offers a bootstrap script in the root of our github

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414209680 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414208743 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414206664 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414205047 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414204309 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414201337 ## README.md: ## @@ -304,8 +304,30 @@ sudo brew install libpcap ### Bootstrapping -- MiNiFi C++ offers a bootstrap script in the root of our github

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-12-04 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1414202235 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-11-30 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1385294428 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import Dict +

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-11-13 Thread via GitHub
lordgamez commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1389526709 ## bootstrap/cli.py: ## @@ -0,0 +1,141 @@ +import os + +import inquirer + +from minifi_option import MinifiOptions +from system_dependency import

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-11-10 Thread via GitHub
szaszm commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1806163996 Got this on Windows, after I managed to install winget and accept the source terms by running it once manually: ``` (venv) C:\a\m\bootstrap>python main.py For CMake to

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-11-07 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1386024240 ## bootstrap/system_dependency.py: ## @@ -0,0 +1,168 @@ +from __future__ import annotations + +import os +import platform +import sys +from typing import Dict +

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-11-07 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1385283642 ## README.md: ## @@ -304,8 +304,30 @@ sudo brew install libpcap ### Bootstrapping -- MiNiFi C++ offers a bootstrap script in the root of our github repo

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-10-18 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1363864275 ## CMakeLists.txt: ## @@ -269,13 +260,12 @@ add_library(ut INTERFACE) target_include_directories(ut SYSTEM INTERFACE

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-10-18 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1363851877 ## .gitignore: ## @@ -48,6 +48,7 @@ cmake-build-debug *flowfile_checkpoint build /*build* +!win_build_vs.bat Review Comment: Yes, the one above it.

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-10-17 Thread via GitHub
szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1362202851 ## CMakeLists.txt: ## @@ -269,13 +260,12 @@ add_library(ut INTERFACE) target_include_directories(ut SYSTEM INTERFACE

[PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2023-10-16 Thread via GitHub
martinzink opened a new pull request, #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: