szaszm closed pull request #1692: MINIFICPP-2217 - Implement jolt processor
shift operation
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
szaszm commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1453383878
##
extensions/standard-processors/processors/JoltTransformJSON.h:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
szaszm commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1453383878
##
extensions/standard-processors/processors/JoltTransformJSON.h:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1453368404
##
extensions/standard-processors/utils/JoltUtils.h:
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1453365651
##
extensions/standard-processors/processors/JoltTransformJSON.h:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
szaszm commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1452196886
##
extensions/standard-processors/utils/JoltUtils.h:
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r185430
##
extensions/standard-processors/processors/JoltTransformJSON.h:
##
Review Comment:
added
--
This is an automated message from the Apache Git
martinzink commented on PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#issuecomment-1878629785
There are some conflicts, could you rebase and make sure the CI is green?
(the current windows build errors seem to be related)
--
This is an automated message from the
martinzink commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1442844633
##
extensions/standard-processors/processors/JoltTransformJSON.h:
##
Review Comment:
pinging @adamdebreceni in case he missed this comment
--
This
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423923909
##
extensions/standard-processors/utils/JoltUtils.cpp:
##
@@ -0,0 +1,1134 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423922940
##
extensions/standard-processors/utils/JoltUtils.cpp:
##
@@ -0,0 +1,1134 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423921251
##
extensions/standard-processors/utils/JoltUtils.cpp:
##
@@ -0,0 +1,1134 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423912281
##
libminifi/test/Utils.h:
##
@@ -48,23 +48,45 @@ using namespace std::literals::chrono_literals;
namespace org::apache::nifi::minifi::test::utils {
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1423912541
##
libminifi/test/Utils.h:
##
@@ -48,23 +48,45 @@ using namespace std::literals::chrono_literals;
namespace org::apache::nifi::minifi::test::utils {
martinzink commented on PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#issuecomment-1851843244
@adamdebreceni Could you rebase and fix conflicts from
https://github.com/apache/nifi-minifi-cpp/pull/1693 ?
--
This is an automated message from the Apache Git Service.
To
fgerlits commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1403618933
##
libminifi/test/Utils.h:
##
@@ -48,23 +48,45 @@ using namespace std::literals::chrono_literals;
namespace org::apache::nifi::minifi::test::utils {
adamdebreceni commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1386425162
##
extensions/standard-processors/processors/JoltTransformJSON.h:
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
martinzink commented on code in PR #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1384582065
##
extensions/standard-processors/processors/JoltTransformJSON.h:
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
adamdebreceni opened a new pull request, #1692:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1692
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
19 matches
Mail list logo
