martinzink closed pull request #1680: MINIFICPP-2248 Refactor string::join_pack
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordgamez commented on code in PR #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1367688644
##
CPPLINT.cfg:
##
@@ -1,2 +1,2 @@
set noparent
szaszm commented on code in PR #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1367522637
##
CPPLINT.cfg:
##
@@ -1,2 +1,2 @@
set noparent
szaszm commented on code in PR #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1367522637
##
CPPLINT.cfg:
##
@@ -1,2 +1,2 @@
set noparent
lordgamez commented on code in PR #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1366849293
##
CPPLINT.cfg:
##
@@ -1,2 +1,2 @@
set noparent
szaszm commented on code in PR #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1362018977
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -469,15 +476,16 @@ TEST_CASE("test string::testJoinPackWstring", "[test
join_pack wstring]") {
==
fgerlits commented on code in PR #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1361673320
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -469,15 +476,16 @@ TEST_CASE("test string::testJoinPackWstring", "[test
join_pack wstring]") {
==
szaszm commented on code in PR #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680#discussion_r1356699329
##
libminifi/include/utils/StringUtils.h:
##
@@ -187,48 +187,40 @@ constexpr size_t size(const
std::basic_string_view& str) noexcept { retur
namespace
szaszm opened a new pull request, #1680:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1680
+ remove obsolete `-fconcepts` flag from `RangeV3.cmake`
+ disable `readability/braces` of cpplint, because it can't handle concepts
---
Thank you for submitting a contribution
