szaszm closed pull request #1707: MINIFICPP-2259 ProcessContext::getProperty
should operate on raw poin…
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
martinzink commented on code in PR #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707#discussion_r1447266560
##
libminifi/src/core/ProcessSession.cpp:
##
@@ -110,36 +109,36 @@ std::shared_ptr
ProcessSession::create(const
fgerlits commented on code in PR #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707#discussion_r1447129423
##
libminifi/src/core/ProcessSession.cpp:
##
@@ -110,36 +109,36 @@ std::shared_ptr
ProcessSession::create(const
martinzink commented on code in PR #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707#discussion_r1431353285
##
extensions/aws/processors/FetchS3Object.h:
##
@@ -46,6 +46,7 @@ class FetchS3Object : public S3Processor {
.supportsExpressionLanguage(true)
szaszm commented on code in PR #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707#discussion_r1425368129
##
extensions/aws/processors/FetchS3Object.h:
##
@@ -46,6 +46,7 @@ class FetchS3Object : public S3Processor {
.supportsExpressionLanguage(true)
martinzink commented on PR #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707#issuecomment-1851594569
Similarly to https://github.com/apache/nifi-minifi-cpp/pull/1693 I'd ask you
to be a bit more lenient with the clang tidy results. I'd rather not refactor
the whole codebase
martinzink opened a new pull request, #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707
…ters
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps
