martinzink commented on PR #79:
URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1866466115
Thanks for quick and thorough reviews and merge @exceptionfactory @szaszm
I will keep an eye on the redesign and do any further improvements based on
that.
--
This is an automated
exceptionfactory closed pull request #79: MINIFICPP-2273 Update minifi
documentation
URL: https://github.com/apache/nifi-site/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martinzink commented on PR #79:
URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1866135336
> Thanks for the update @martinzink! I may have missed this earlier, but
similar to the about pages, it seems better to keep one MiNiFi Download page,
with separate sections for C++ and
exceptionfactory commented on PR #79:
URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1864677009
Thanks for the update @martinzink! I may have missed this earlier, but
similar to the about pages, it seems better to keep one MiNiFi Download page,
with separate sections for C++
martinzink commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1432848742
##
source/minifi/minifi-java-about.md:
##
@@ -0,0 +1,4 @@
+### MiNiFi Java
Review Comment:
It looks like I accidentally deleted the wrong file before, (removed
exceptionfactory commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1432790682
##
source/minifi/minifi-java-about.md:
##
@@ -0,0 +1,4 @@
+### MiNiFi Java
Review Comment:
It looks like this file can be deleted.
##
martinzink commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1431113253
##
source/minifi/minifi-java-guide-pushing-nifi-minifi.md:
##
@@ -94,7 +50,7 @@ No validation errors found in template.
```
Open the config.yml file and add Port
szaszm commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1430705043
##
source/minifi/minifi-java-about.md:
##
@@ -0,0 +1,4 @@
+### MiNiFi Java
+The Java agent is built from the same codebase as NiFi, enabling it to run
most of [NiFi's
martinzink commented on PR #79:
URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1860945190
> > > Thanks for making the updates @martinzink.
> > > Looking at the latest version, I think it would be better to
introducing the new about pages and simply have two separate
exceptionfactory commented on PR #79:
URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1860597378
> > Thanks for making the updates @martinzink.
> > Looking at the latest version, I think it would be better to introducing
the new about pages and simply have two separate
martinzink commented on PR #79:
URL: https://github.com/apache/nifi-site/pull/79#issuecomment-1859989493
> Thanks for making the updates @martinzink.
>
> Looking at the latest version, I think it would be better to introducing
the new about pages and simply have two separate sections
szaszm commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1426826818
##
source/minifi/minifi-java-guide-pushing-nifi-minifi.md:
##
@@ -94,7 +50,7 @@ No validation errors found in template.
```
Open the config.yml file and add Port and
martinzink commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1426812556
##
source/minifi/faq.md:
##
@@ -9,3 +9,18 @@ containerEnabled: true
### How do you pronounce MiNiFi?
"minify" (_min_-uh-fahy) is the preferred pronunciation.
+
+
martinzink commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1426808647
##
source/minifi/minifi-cpp-agent-quick-start.md:
##
@@ -0,0 +1,26 @@
+---
+title: Apache NiFi MiNiFi Java Agent Quick Start Guide
+menu: minifi-topbar.html
exceptionfactory commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1425472074
##
source/minifi/minifi-cpp-agent-quick-start.md:
##
@@ -0,0 +1,26 @@
+---
+title: Apache NiFi MiNiFi Java Agent Quick Start Guide
+menu: minifi-topbar.html
exceptionfactory commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1425470694
##
source/minifi/getting-started.md:
##
@@ -1,124 +1,42 @@
---
-title: Apache NiFi MiNiFi Getting Started
Review Comment:
The Getting Started page does
exceptionfactory commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1425468973
##
source/minifi/faq.md:
##
@@ -9,3 +9,18 @@ containerEnabled: true
### How do you pronounce MiNiFi?
"minify" (_min_-uh-fahy) is the preferred
szaszm commented on code in PR #79:
URL: https://github.com/apache/nifi-site/pull/79#discussion_r1425448988
##
source/minifi/faq.md:
##
@@ -9,3 +9,18 @@ containerEnabled: true
### How do you pronounce MiNiFi?
"minify" (_min_-uh-fahy) is the preferred pronunciation.
+
+
+###
martinzink opened a new pull request, #79:
URL: https://github.com/apache/nifi-site/pull/79
I've restructred minifi's documentation a little bit.
There were two sites previously with very similar information.
https://nifi.apache.org/minifi/getting-started.html
19 matches
Mail list logo
