Re: [PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]

2024-02-14 Thread via GitHub
fgerlits commented on code in PR #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722#discussion_r1489736588 ## docker/test/integration/resources/python/RotatingForwarder.py: ## Review Comment: yes, that sounds good -- This is an automated message from the Ap

Re: [PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]

2024-02-14 Thread via GitHub
lordgamez commented on code in PR #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722#discussion_r1489401260 ## docker/test/integration/resources/python/RotatingForwarder.py: ## Review Comment: I would rename it to "custom relationship" and set the `SupportsDyn

Re: [PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]

2024-02-14 Thread via GitHub
fgerlits commented on code in PR #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722#discussion_r1489328963 ## docker/test/integration/resources/python/RotatingForwarder.py: ## Review Comment: Should we give it a different name? It's a bit confusing that we use

Re: [PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]

2024-02-13 Thread via GitHub
lordgamez commented on code in PR #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722#discussion_r1488278314 ## docker/test/integration/resources/python/RotatingForwarder.py: ## Review Comment: The goal of this PR is to support the same dynamic relationships tha

Re: [PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]

2024-02-13 Thread via GitHub
lordgamez commented on code in PR #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722#discussion_r1488278314 ## docker/test/integration/resources/python/RotatingForwarder.py: ## Review Comment: The goal of this PR is to support the same dynamic relationships tha

Re: [PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]

2024-02-13 Thread via GitHub
fgerlits commented on code in PR #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722#discussion_r1488262406 ## docker/test/integration/resources/python/RotatingForwarder.py: ## Review Comment: This is not the best example of dynamic relationships, since all the

[PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]

2024-02-06 Thread via GitHub
lordgamez opened a new pull request, #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722 https://issues.apache.org/jira/browse/MINIFICPP-2278 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of