szaszm closed pull request #1739: MINIFICPP-2282 Support re-encryption of
sensitive properties
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1536612041
##
libminifi/include/core/json/JsonFlowSerializer.h:
##
@@ -26,12 +26,12 @@ class JsonFlowSerializer : public
core::flow::FlowSerializer {
explicit
szaszm commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1532567319
##
libminifi/include/core/json/JsonFlowSerializer.h:
##
@@ -26,12 +26,12 @@ class JsonFlowSerializer : public
core::flow::FlowSerializer {
explicit
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1532461193
##
libminifi/include/core/json/JsonFlowSerializer.h:
##
@@ -26,12 +26,12 @@ class JsonFlowSerializer : public
core::flow::FlowSerializer {
explicit
szaszm commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1532443851
##
libminifi/include/core/json/JsonFlowSerializer.h:
##
@@ -26,12 +26,12 @@ class JsonFlowSerializer : public
core::flow::FlowSerializer {
explicit
fgerlits commented on PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#issuecomment-2010035820
There is a problem with this pull request: if you run `encrypt-config
flow-config --re-encrypt` twice, then it encrypts the already-encrypted
properties a second time, making
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1525096660
##
encrypt-config/EncryptConfigMain.cpp:
##
Review Comment:
fixed in e8ca161921504becfb0044d1e86828bcb4a3ce98
--
This is an automated message from
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1525096141
##
encrypt-config/EncryptConfigMain.cpp:
##
@@ -62,18 +65,19 @@ int main(int argc, char* argv[]) try {
if (operation == OPERATION_MINIFI_PROPERTIES) {
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1522975112
##
encrypt-config/EncryptConfigMain.cpp:
##
Review Comment:
it is set to an encrypted empty string, but I agree that we should not add
new properties
lordgamez commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1519863114
##
encrypt-config/EncryptConfigMain.cpp:
##
Review Comment:
I encrypted a flow config in interactive mode using a `PutS3Object`
processor which has 2
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1512504892
##
encrypt-config/FlowConfigEncryptor.cpp:
##
@@ -61,114 +62,150 @@ std::vector
listSensitiveProperties(const minifi::core::Proce
std::vector
szaszm commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1511197680
##
encrypt-config/FlowConfigEncryptor.cpp:
##
@@ -61,114 +62,150 @@ std::vector
listSensitiveProperties(const minifi::core::Proce
std::vector processors;
fgerlits opened a new pull request, #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739
Added a new `--re-encrypt` option to the `flow-config` action of the
`encrypt-config` binary, which can decrypt the sensitive properties using the
`.old` key and re-encrypt them with a new
13 matches
Mail list logo
