Re: [PR] MINIFICPP-2296 - Install service on macOS [nifi-minifi-cpp]

2024-03-12 Thread via GitHub
martinzink closed pull request #1726: MINIFICPP-2296 - Install service on macOS URL: https://github.com/apache/nifi-minifi-cpp/pull/1726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] MINIFICPP-2296 - Install service on macOS [nifi-minifi-cpp]

2024-02-15 Thread via GitHub
adamdebreceni commented on code in PR #1726: URL: https://github.com/apache/nifi-minifi-cpp/pull/1726#discussion_r1490763055 ## bin/minifi.sh: ## @@ -94,39 +105,93 @@ uninstall() { systemctl daemon-reload } -check_service_installed() { +check_service_installed_linux() {

Re: [PR] MINIFICPP-2296 - Install service on macOS [nifi-minifi-cpp]

2024-02-14 Thread via GitHub
szaszm commented on code in PR #1726: URL: https://github.com/apache/nifi-minifi-cpp/pull/1726#discussion_r1489830838 ## bin/minifi.sh: ## @@ -94,39 +105,93 @@ uninstall() { systemctl daemon-reload } -check_service_installed() { +check_service_installed_linux() { if

[PR] MINIFICPP-2296 - Install service on macOS [nifi-minifi-cpp]

2024-02-14 Thread via GitHub
adamdebreceni opened a new pull request, #1726: URL: https://github.com/apache/nifi-minifi-cpp/pull/1726 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been take