Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-11 Thread via GitHub
fgerlits closed pull request #1792: MINIFICPP-2367 Add support for non-sensitive parameters URL: https://github.com/apache/nifi-minifi-cpp/pull/1792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-09 Thread via GitHub
lordgamez commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1670732275 ## libminifi/include/core/FlowConfiguration.h: ## @@ -134,6 +135,7 @@ class FlowConfiguration : public CoreComponent { utils::ChecksumCalculator& getChecks

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-09 Thread via GitHub
lordgamez commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1670704775 ## libminifi/src/core/ParameterTokenParser.cpp: ## @@ -0,0 +1,105 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-09 Thread via GitHub
szaszm commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1670609030 ## libminifi/include/core/FlowConfiguration.h: ## @@ -134,6 +135,7 @@ class FlowConfiguration : public CoreComponent { utils::ChecksumCalculator& getChecksumC

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-09 Thread via GitHub
szaszm commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1670605385 ## libminifi/src/core/ParameterTokenParser.cpp: ## @@ -0,0 +1,105 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-08 Thread via GitHub
lordgamez commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1668807387 ## libminifi/include/core/ProcessGroup.h: ## @@ -217,6 +217,9 @@ class ProcessGroup : public CoreComponent { void verify() const; + void setParameterC

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-08 Thread via GitHub
lordgamez commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1668752869 ## CONFIGURE.md: ## @@ -121,8 +124,101 @@ It's recommended to create your configuration in YAML format or configure the ag max concurrent ta

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-08 Thread via GitHub
lordgamez commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1668741513 ## libminifi/include/core/ConfigurableComponent.h: ## @@ -136,6 +136,8 @@ class ConfigurableComponent { */ bool getDynamicProperty(const std::string& n

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-08 Thread via GitHub
lordgamez commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1668693502 ## extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp: ## @@ -1072,3 +1075,581 @@ TEST_CASE("Test serialization", "[YamlConfiguration]") {

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-08 Thread via GitHub
lordgamez commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1668693502 ## extensions/standard-processors/tests/unit/YamlConfigurationTests.cpp: ## @@ -1072,3 +1075,581 @@ TEST_CASE("Test serialization", "[YamlConfiguration]") {

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-08 Thread via GitHub
szaszm commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1668618742 ## CONFIGURE.md: ## @@ -121,8 +124,101 @@ It's recommended to create your configuration in YAML format or configure the ag max concurrent tasks

Re: [PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-07-02 Thread via GitHub
szaszm commented on code in PR #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1627977636 ## libminifi/include/core/ProcessGroup.h: ## @@ -217,6 +217,9 @@ class ProcessGroup : public CoreComponent { void verify() const; + void setParameterCont

[PR] MINIFICPP-2367 Add support for non-sensitive parameters [nifi-minifi-cpp]

2024-05-21 Thread via GitHub
lordgamez opened a new pull request, #1792: URL: https://github.com/apache/nifi-minifi-cpp/pull/1792 https://issues.apache.org/jira/browse/MINIFICPP-2367 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the