dan-s1 opened a new pull request, #8005:
URL: https://github.com/apache/nifi/pull/8005
# Summary
[NIFI-11627](https://issues.apache.org/jira/browse/NIFI-11627)
# Tracking
Please complete the following tracking steps prio
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1808551126
Where would a `json-schema-shared` go in the Maven hiearchy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
exceptionfactory commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1808718378
> Where would a `json-schema-shared` go in the Maven hiearchy? Could I
possibly put the `PropertyDescriptor ` in the `JsonSchemaRegistry` interface
and then not need `json-schema-sh
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1808721485
Sure but could I possibly put the PropertyDescriptor in the
JsonSchemaRegistry interface and then not need `json-schema-shared`?
--
This is an automated message from the Apache Git Service
exceptionfactory commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1808724417
> Sure but could I possibly put the PropertyDescriptor in the
JsonSchemaRegistry interface and then not need `json-schema-shared`?
Although it is a semantic difference, it is
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1809041146
If I make the changes soon, will this be available for the 1.24 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
exceptionfactory commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1809061757
> If I make the changes soon, will this be available for the 1.24 release?
We are in the process of preparing the initial release candidates for 1.24.0
and 2.0.0-M1 as describ
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1819450265
@exceptionfactory Looks like the failure from the build on Windows Zulu JDK
21 FR has nothing to do with my changes.
--
This is an automated message from the Apache Git Service.
To respond
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1840842508
@exceptionfactory Can you please restart the build which failed? It does not
seem to have failed as a result of the changes I made.
Thank you!
--
This is an automated message from the Ap
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1841173185
@exceptionfactory Sorry to bother you to restart this. This is the exception
I see its encountering
`Error: Failed to execute goal
com.github.eirslett:frontend-maven-plugin:1.14.2:install
exceptionfactory commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1841235544
> @exceptionfactory This is the exception I see its encountering which has
nothing to do with my changes. `Error: Failed to execute goal
com.github.eirslett:frontend-maven-plugin:1.
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416003586
##
nifi-commons/nifi-json-schema-api/src/main/java/org/apache/nifi/schema/access/JsonSchema.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foun
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416045115
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416049310
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416045115
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416126018
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416162547
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416188685
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416188685
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416188685
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416188685
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1416213317
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420455910
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420455910
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420462605
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420491373
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420507222
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420614969
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420621232
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1420661560
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/src/main/java/org/apache/nifi/schemaregistry/services/InMemoryJsonSchemaRegistry.java:
##
@@ -0,0 +1,156 @@
+
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1847516537
@exceptionfactory Sorry I had a Checkstyle violation as I had not removed an
unused import. I have fixed that and pushed the change. Can you please at your
earliest convenience restart the bu
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1854671022
@exceptionfactory I know you are a busy man but when you get a chance can
you please review the latest changes? Thank you!
--
This is an automated message from the Apache Git Service.
To re
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1435301326
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java:
##
@@ -79,65 +92,69 @@
dan-s1 commented on PR #8005:
URL: https://github.com/apache/nifi/pull/8005#issuecomment-1869144546
@exceptionfactory The failure of the 'dependency-check / Dependency Check'
build seems to be unrelated to my changes. Error message is
```
Unable to download meta file:
https://nv
exceptionfactory closed pull request #8005: NIFI-11627 Added an in memory JSON
schema registry which ValidationJson can now use to retrieve JSON schemas from
for validation.
URL: https://github.com/apache/nifi/pull/8005
--
This is an automated message from the Apache Git Service.
To respond
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389824324
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389836854
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389837400
##
nifi-nar-bundles/nifi-registry-bundle/nifi-registry-service/pom.xml:
##
@@ -52,5 +57,22 @@ language governing permissions and limitations under the
License. -->
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389836854
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389836854
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389838465
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389838896
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389839102
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389840412
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389857197
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389857197
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389872490
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389874852
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389874852
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389874852
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389874852
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1389887565
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema
dan-s1 commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1390482375
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1391181164
##
nifi-commons/nifi-json-schema-utils/pom.xml:
##
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema
54 matches
Mail list logo