Re: [PR] NIFI-11739: Add ability to ignore missing fields in PutIceberg [nifi]

2023-10-03 Thread via GitHub
asfgit closed pull request #7421: NIFI-11739: Add ability to ignore missing fields in PutIceberg URL: https://github.com/apache/nifi/pull/7421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] NIFI-11739: Add ability to ignore missing fields in PutIceberg [nifi]

2023-10-03 Thread via GitHub
pvillard31 commented on PR #7421: URL: https://github.com/apache/nifi/pull/7421#issuecomment-1744787034 Thanks @mattyb149 and thanks for the review @mark-bathori , merging now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] NIFI-11739: Add ability to ignore missing fields in PutIceberg [nifi]

2023-10-02 Thread via GitHub
mark-bathori commented on code in PR #7421: URL: https://github.com/apache/nifi/pull/7421#discussion_r1342676660 ## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-common/src/main/java/org/apache/nifi/processors/iceberg/converter/IcebergRecordConverter.java: ## @@ -156,8 +174,

Re: [PR] NIFI-11739: Add ability to ignore missing fields in PutIceberg [nifi]

2023-10-02 Thread via GitHub
mark-bathori commented on code in PR #7421: URL: https://github.com/apache/nifi/pull/7421#discussion_r1342539976 ## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/test/java/org/apache/nifi/processors/iceberg/TestIcebergRecordConverter.java: ## @@ -433,11 +494,1