markap14 merged PR #7875:
URL: https://github.com/apache/nifi/pull/7875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markap14 commented on PR #7875:
URL: https://github.com/apache/nifi/pull/7875#issuecomment-1772876906
Great, thanks @bbende, merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markap14 commented on code in PR #7875:
URL: https://github.com/apache/nifi/pull/7875#discussion_r1367075338
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerResource.java:
##
@@ -449,6 +455,72 @@
bbende commented on PR #7875:
URL: https://github.com/apache/nifi/pull/7875#issuecomment-1772874845
@markap14 yes that would be great! Really appreciate the review and testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
markap14 commented on PR #7875:
URL: https://github.com/apache/nifi/pull/7875#issuecomment-1772871187
Was able to test and all looks good. Given that the only I had was a trivial
change, I can make that change and merge if you're good with that @bbende
--
This is an automated message
markap14 commented on PR #7875:
URL: https://github.com/apache/nifi/pull/7875#issuecomment-1771678073
Thanks for adding this in @bbende. Code review looks good, aside from the
one note that I made inline about referencing the wrong entity. Still need to
do some testing but in terms of the
markap14 commented on code in PR #7875:
URL: https://github.com/apache/nifi/pull/7875#discussion_r1366083844
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerResource.java:
##
@@ -449,6 +455,72 @@
bbende opened a new pull request, #7875:
URL: https://github.com/apache/nifi/pull/7875
# Summary
[NIFI-12198](https://issues.apache.org/jira/browse/NIFI-12198)
# Tracking
Please complete the following tracking steps