Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-10 Thread via GitHub
briansolo1985 closed pull request #7997: NIFI-12333 MiNiFi property override through env and system variables URL: https://github.com/apache/nifi/pull/7997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
ferencerdei commented on PR #7997: URL: https://github.com/apache/nifi/pull/7997#issuecomment-1804007639 Thanks for the comments, I've applied them. Also needed to rename / create a new minifi-commons-utils module, hope it doesn't make the change too noisy. -- This is an automated messag

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
ferencerdei commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1388140508 ## minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/main/java/org/apache/nifi/minifi/util/MiNiFiProperties.java: ## @@ -0,0 +1,88

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
ferencerdei commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1388139084 ## minifi/minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/util/PropertyUtil.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache So

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
ferencerdei commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1388138427 ## minifi/minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/util/PropertyUtil.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache So

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
ferencerdei commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1388137175 ## minifi/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/service/BootstrapProperties.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
ferencerdei commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1388136691 ## minifi/minifi-commons/minifi-utils/src/test/java/org/apache/nifi/minifi/commons/status/util/PropertyUtilTest.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apach

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
ferencerdei commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1387676651 ## minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/src/main/java/org/apache/nifi/minifi/util/MiNiFiProperties.java: ## @@ -0,0 +1,88

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-09 Thread via GitHub
bejancsaba commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1387659456 ## minifi/minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/util/PropertyUtil.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Sof

Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-08 Thread via GitHub
briansolo1985 commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1386758472 ## minifi/minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/util/PropertyUtil.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

[PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-08 Thread via GitHub
ferencerdei opened a new pull request, #7997: URL: https://github.com/apache/nifi/pull/7997 # Summary [NIFI-12333](https://issues.apache.org/jira/browse/NIFI-12333) # Tracking Please complete the following tracking steps