rliszli closed pull request #8015: NIFI-12351 Improve MiNiFi Service Scripts
for Windows
URL: https://github.com/apache/nifi/pull/8015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
rliszli commented on PR #8015:
URL: https://github.com/apache/nifi/pull/8015#issuecomment-2031746756
@exceptionfactory: We still have one issue that needs to be addressed. I'll
close the PR until it gets resolved.
--
This is an automated message from the Apache Git Service.
To respond to
exceptionfactory commented on PR #8015:
URL: https://github.com/apache/nifi/pull/8015#issuecomment-2019318631
@rliszli and @bejancsaba any updates on bringing this pull request to
completion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
exceptionfactory commented on PR #8015:
URL: https://github.com/apache/nifi/pull/8015#issuecomment-1894866499
@rliszli This seems close to completion, aside from the one merge conflict.
@bejancsaba I will defer to you for further review.
--
This is an automated message from the Apache Git
rliszli commented on code in PR #8015:
URL: https://github.com/apache/nifi/pull/8015#discussion_r1419023938
##
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/bin/delete-service.bat:
##
@@ -16,8 +16,16 @@ remSee the Lice
rliszli commented on PR #8015:
URL: https://github.com/apache/nifi/pull/8015#issuecomment-1845418710
`Thanks for the changes it is an area which clearly can benefit from some
improvement. Maybe something is not right on my side but I'm getting the
following`
Previously I only tested it o
bejancsaba commented on code in PR #8015:
URL: https://github.com/apache/nifi/pull/8015#discussion_r1404636904
##
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/bin/install-service.bat:
##
@@ -65,12 +125,21 @@ set LOG_PREFI
rliszli commented on PR #8015:
URL: https://github.com/apache/nifi/pull/8015#issuecomment-1818427167
Thanks for the suggestions and for the better naming. I added a short list
for this PR containing the main elements of the change. I'll also update the
`minifi-java-agent-quick-start.md` wit
exceptionfactory commented on PR #8015:
URL: https://github.com/apache/nifi/pull/8015#issuecomment-1813705379
Concurring with @bejancsaba, it would be helpful to elaborate on the goal of
these changes. I updated the pull request title to reflect that fact that the
changes related to service
