exceptionfactory closed pull request #8042: NIFI-12382: Add
DatabaseSchemaRegistry service
URL: https://github.com/apache/nifi/pull/8042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
exceptionfactory commented on code in PR #8042:
URL: https://github.com/apache/nifi/pull/8042#discussion_r1415801708
##
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-db-schema-registry-service/src/main/java/org/apache/nifi/db/schemaregistry/DatabaseTableSchemaReg
exceptionfactory commented on code in PR #8042:
URL: https://github.com/apache/nifi/pull/8042#discussion_r1398201746
##
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-db-schema-registry-service/pom.xml:
##
@@ -0,0 +1,76 @@
+
+
+http://maven.apache.org/POM/
exceptionfactory commented on code in PR #8042:
URL: https://github.com/apache/nifi/pull/8042#discussion_r1397676848
##
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-db-schema-registry-service/src/main/java/org/apache/nifi/db/schemaregistry/DatabaseSchemaRegistry
mattyb149 commented on code in PR #8042:
URL: https://github.com/apache/nifi/pull/8042#discussion_r1397661227
##
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-db-schema-registry-service/src/main/java/org/apache/nifi/db/schemaregistry/DatabaseSchemaRegistry.java:
mattyb149 commented on code in PR #8042:
URL: https://github.com/apache/nifi/pull/8042#discussion_r1397658749
##
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-db-schema-registry-service/pom.xml:
##
@@ -0,0 +1,76 @@
+
+
+http://maven.apache.org/POM/4.0.0";
mattyb149 commented on code in PR #8042:
URL: https://github.com/apache/nifi/pull/8042#discussion_r1397657327
##
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-db-schema-registry-service/pom.xml:
##
@@ -0,0 +1,76 @@
+
+
+http://maven.apache.org/POM/4.0.0";
exceptionfactory commented on code in PR #8042:
URL: https://github.com/apache/nifi/pull/8042#discussion_r1397647623
##
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-db-schema-registry-service/src/main/java/org/apache/nifi/db/schemaregistry/DatabaseSchemaRegistry
exceptionfactory commented on PR #8042:
URL: https://github.com/apache/nifi/pull/8042#issuecomment-1816579844
Thanks for the additional input @pvillard31, that is helpful, and makes more
sense now.
I realize that I was not evaluating all the implementation details. Now I
see that the
pvillard31 commented on PR #8042:
URL: https://github.com/apache/nifi/pull/8042#issuecomment-1816560628
I'm jumping in the conversation here but I don't think this is a very
specific use case. The idea is that, in many cases, data would be sent into a
database by NiFi and some users may not
exceptionfactory commented on PR #8042:
URL: https://github.com/apache/nifi/pull/8042#issuecomment-1816528314
Thanks for the reply @mattyb149. Renaming the class could be helpful.
Another potential concern is using the schema name as the table name. Aside
from schema naming convention
mattyb149 commented on PR #8042:
URL: https://github.com/apache/nifi/pull/8042#issuecomment-1815409306
I'll add more documentation around the use case and what this service does,
but I didn't see any use for a DB-backed registry that just stores schema text
(such as a String column containi
mattyb149 opened a new pull request, #8042:
URL: https://github.com/apache/nifi/pull/8042
# Summary
[NIFI-12382](https://issues.apache.org/jira/browse/NIFI-12382) This PR adds
a DatabaseSchemaRegistry controller service which gets the metadata for a
specified database table and creat
13 matches
Mail list logo