Re: [PR] NIFI-12530: Support CREATE TABLE in Oracle database adapters [nifi]

2024-01-11 Thread via GitHub
asfgit closed pull request #8175: NIFI-12530: Support CREATE TABLE in Oracle database adapters URL: https://github.com/apache/nifi/pull/8175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] NIFI-12530: Support CREATE TABLE in Oracle database adapters [nifi]

2024-01-11 Thread via GitHub
gresockj commented on PR #8175: URL: https://github.com/apache/nifi/pull/8175#issuecomment-1888304578 Thanks for the reviews -- I will merge this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] NIFI-12530: Support CREATE TABLE in Oracle database adapters [nifi]

2023-12-21 Thread via GitHub
mattyb149 commented on PR #8175: URL: https://github.com/apache/nifi/pull/8175#issuecomment-1866377704 I didn't add the unit test to the older OracleDatabaseAdapter because it was basically copy/paste, but since the new code is too, I will add that test to it. The only reason for using the

Re: [PR] NIFI-12530: Support CREATE TABLE in Oracle database adapters [nifi]

2023-12-20 Thread via GitHub
EndzeitBegins commented on PR #8175: URL: https://github.com/apache/nifi/pull/8175#issuecomment-1865155224 Thank you for working on this @mattyb149.  I just glanced over the code and have two remarks. Is there a reason, there is no test added for the `OracleDatabaseAdapter`

[PR] NIFI-12530: Support CREATE TABLE in Oracle database adapters [nifi]

2023-12-20 Thread via GitHub
mattyb149 opened a new pull request, #8175: URL: https://github.com/apache/nifi/pull/8175 # Summary [NIFI-12530](https://issues.apache.org/jira/browse/NIFI-12530) This PR adds support for CREATE TABLE (via UpdateDatabaseRecord) for the two existing Oracle database adapters. #