exceptionfactory closed pull request #8249: NIFI-12554 Placed all Jolt related
code under a new nifi-jolt-bundle and refactored to reduce duplicate code.
URL: https://github.com/apache/nifi/pull/8249
--
This is an automated message from the Apache Git Service.
To respond to the message,
exceptionfactory commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1900749975
> > nifi-standard-shared-nar
>
> > @dan-s1 in the process of testing, it is clear that the
migrateProperties method is not useful in this scenario. I wasn't quite clear
on
dan-s1 commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1900735102
> nifi-standard-shared-nar
> @dan-s1 in the process of testing, it is clear that the migrateProperties
method is not useful in this scenario. I wasn't quite clear on the
exceptionfactory commented on code in PR #8249:
URL: https://github.com/apache/nifi/pull/8249#discussion_r1454379609
##
nifi-nar-bundles/nifi-jolt-bundle/nifi-jolt-processors/src/main/java/org/apache/nifi/processors/jolt/AbstractJoltTransform.java:
##
@@ -0,0 +1,255 @@
+/*
+ *
dan-s1 commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1896124104
> Thank you for working on this @dan-s1.
>
> I haven't done a full code review so I might've just overlooked something.
But I noticed that the package names of the processors change
dan-s1 commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1894633928
@exceptionfactory I am now able to see the stacktraces from the builds.
Apparently there was also an issue with the `nifi-standard-utils` which no
longer exists. So I removed both
exceptionfactory commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1894557055
> @exceptionfactory Do I need to add the new modules I created to
`nifi-code-coverage` `pom.xml`? Which ones do I add `nifi-jolt-processors` and
`nifi-jolt-utils` ?
Yes,
dan-s1 commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1894548409
@exceptionfactory Do I need to add the new modules I created to
`nifi-code-coverage` `pom.xml`? Which ones do I add `nifi-jolt-processors` and
`nifi-jolt-utils` ?
--
This is an automated
dan-s1 commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1894290354
@exceptionfactory Thanks for clarifying what the builds were failing on as I
could not see that. I only saw Error:
--
This is an automated message from the Apache Git Service.
To respond
EndzeitBegins commented on PR #8249:
URL: https://github.com/apache/nifi/pull/8249#issuecomment-1893105650
Thank you for working on this @dan-s1.
I haven't done a full code review so I might've just overlooked something.
But I noticed that the package names of the processors
dan-s1 commented on code in PR #8249:
URL: https://github.com/apache/nifi/pull/8249#discussion_r1452774911
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-nar/src/main/resources/META-INF/NOTICE:
##
@@ -10,7 +10,7 @@ This product includes the following work from the
dan-s1 commented on code in PR #8249:
URL: https://github.com/apache/nifi/pull/8249#discussion_r1452773110
##
nifi-nar-bundles/nifi-standard-bundle/pom.xml:
##
@@ -265,7 +290,7 @@
com.networknt
json-schema-validator
-
exceptionfactory commented on code in PR #8249:
URL: https://github.com/apache/nifi/pull/8249#discussion_r1452770561
##
nifi-nar-bundles/nifi-jolt-bundle/pom.xml:
##
@@ -57,6 +45,22 @@
json-utils
${jolt.version}
+
+
dan-s1 opened a new pull request, #8249:
URL: https://github.com/apache/nifi/pull/8249
…
# Summary
[NIFI-12554](https://issues.apache.org/jira/browse/NIFI-12554)
# Tracking
Please complete the following tracking
14 matches
Mail list logo
